Plugins fail on Windows

Question

Plugins fail on Windows

qinyouzhi opened this issue a year ago · comments

qinyouzhi commented a year ago

Inconsistent path addresses between Mac and Windows (Mac:/ Windows: ), resulting in plugin failure on Windows

qinyouzhi · Answer 1 · Wed Aug 30 2023 18:51:10 GMT+0800 (China Standard Time)

Inconsistent path addresses between Mac and Windows (Mac:/ Windows: \), resulting in plugin failure on Windows

Bjorn Lu · Answer 2 · Fri Sep 01 2023 13:44:30 GMT+0800 (China Standard Time)

I don't have a windows machine to test out, and the issue description is vague. Can you further elaborate the issue you're seeing?

qinyouzhi · Answer 3 · Fri Sep 01 2023 15:44:23 GMT+0800 (China Standard Time)

In @whyframe/jsx/src/docusaurus.cjs, the matching rule for rule @docusaurus/mdx-loader in Windows is actually @Docusaurus\mdx-loader, which causes the loader to fail to mount

qinyouzhi · Answer 4 · Fri Sep 01 2023 15:47:43 GMT+0800 (China Standard Time)

There is also an issue with the 'this. resource' in loader.cjs. Change it to path.relative(__dirname, this.resource).split(path.sep).join('/') and run it

Bjorn Lu · Answer 5 · Mon Sep 04 2023 10:42:58 GMT+0800 (China Standard Time)

Sorry for the late reply, thanks for digging into this!

The changes for @docusaurus/mdx-loader sounds good to me.
For this.resource, maybe it's better to use this.resourcePath instead? Would be great if you can test if this works.

Feel free to send a PR for the two changes too. Don't think we need tests for those for now, I should update CI to also run them in Windows.