Save doesn't save in the origin format

Question

Save doesn't save in the origin format

m21-cerutti opened this issue 4 years ago · comments

When saving a yarn script, put instead a json syntax inside the file by default.
Also after closing, it freeze the editor because of the bad formatting and need to delete the roaming folder.

On Version 0.4.124.

TralMac · Answer 1 · Thu Apr 22 2021 13:52:11 GMT+0800 (China Standard Time)

i have meet the same problem

hsallander · Answer 2 · Tue Jun 01 2021 19:50:12 GMT+0800 (China Standard Time)

We have the same issue on Windows version 0.4.124 (on Mac we don't have this issue). Steps to reproduce:

Open a file, for example dialogue.yarn, in the YarnEditor
Save it using the shortcut Ctrl->s (or go File -> Save)
The file is now saved with the .yarn extension but in json format and thus can't be read by Yarnspinner in our Unity project (currently we're on version 1.2.7)

The only workaround we've found is to manually do File -> Save as Yarn every time

@blurymind or any other YarnEditor devs, do you know if there's a fix for this bug in the pipeline?

Todor Imreorov · Answer 3 · Tue Jun 01 2021 19:51:49 GMT+0800 (China Standard Time)

this should be easy to fix. The save command should respect the last format that was previously used, but it doesnt.

…

On Tue, Jun 1, 2021 at 12:50 PM hsallander ***@***.***> wrote: We have the same issue on Windows version 0.4.124 (on Mac we don't have this issue). Steps to reproduce: - Open a file, for example dialogue.yarn, in the YarnEditor - Save it using the shortcut Ctrl->s (or go File -> Save) - The file is now saved with the .yarn extension but in json format and thus can't be read by Yarnspinner in our Unity project (currently we're on version 1.2.7) The only workaround we've found is to manually do File -> Save as Yarn every time @blurymind <https://github.com/blurymind> or any other YarnEditor devs, do you know if there's a fix for this bug in the pipeline? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/YarnSpinnerTool/YarnEditor/issues/257#issuecomment-852061223>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRRWVOTNPRLBMJYPGVT6JLTQTCQHANCNFSM43DJ226Q> .

yOYo · Answer 4 · Thu Jul 01 2021 02:18:55 GMT+0800 (China Standard Time)

Same issue, but save as yarn doesnt work.

Todor Imreorov · Answer 5 · Thu Jul 01 2021 06:17:30 GMT+0800 (China Standard Time)

Do you get some error in the console?

…

On Wed, 30 Jun 2021, 19:19 Yulovery, ***@***.***> wrote: Same issue, but save as yarn doesnt work. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/YarnSpinnerTool/YarnEditor/issues/257#issuecomment-871627190>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRRWVNOV6ZA3J7LPJ7BJY3TVNNZRANCNFSM43DJ226Q> .

yOYo · Answer 6 · Thu Jul 01 2021 20:50:31 GMT+0800 (China Standard Time)

Do you get some error in the console?
…
On Wed, 30 Jun 2021, 19:19 Yulovery, @.***> wrote: Same issue, but save as yarn doesnt work. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#257 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRWVNOV6ZA3J7LPJ7BJY3TVNNZRANCNFSM43DJ226Q .

Not during saving. You know it doesnt work becuase you cant open it any longer and it doest have the green yarn icon in unity, the white yarn icon if it is saved in yarn fromat but currpted. The unity consel does some sya error at line 1 "[" or just
completely ignore the yarn file.

Todor Imreorov · Answer 7 · Thu Jul 01 2021 21:25:02 GMT+0800 (China Standard Time)

i am confused. So you do get a file with the same name as before but unity can no longer parse it? Can you make a video or a gif of exactly what you are doing? If you are getting some file out or file gets modified, what do you see in the file after you edit it with a text editor?

…

On Thu, Jul 1, 2021 at 1:50 PM Yulovery ***@***.***> wrote: Do you get some error in the console? … <#m_2578517092183396939_> On Wed, 30 Jun 2021, 19:19 Yulovery, *@*.***> wrote: Same issue, but save as yarn doesnt work. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#257 (comment) <https://github.com/YarnSpinnerTool/YarnEditor/issues/257#issuecomment-871627190>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRWVNOV6ZA3J7LPJ7BJY3TVNNZRANCNFSM43DJ226Q . Not during saving. You know it doesnt work becuase you cant open it any longer and it doest have the green yarn icon in unity, the white yarn icon if it is saved in yarn fromat but currpted. The unity consel does some sya error at line 1 "[" or just completely ignore the yarn file. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/YarnSpinnerTool/YarnEditor/issues/257#issuecomment-872219136>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRRWVI4J5GGR4SH5KORZXLTVRQCDANCNFSM43DJ226Q> .

Todor Imreorov · Answer 8 · Thu Jul 01 2021 21:25:25 GMT+0800 (China Standard Time)

I do not have or use unity btw :) Have no way of replicating whats happening specifically with unity

Todor Imreorov · Answer 9 · Sun Jul 11 2021 01:42:21 GMT+0800 (China Standard Time)

I fixed the ctrl+s bug via YarnSpinnerTool/YarnEditor@a7075bd -now it should save with the same file format as is used. Please open a separate issue for anything else

dill0wn · Answer 10 · Sun Dec 19 2021 08:04:55 GMT+0800 (China Standard Time)

Was this tested? I'm seeing the same problem, but where my .yarn file is saved in JSON format. I don't think this fix fixed what it was supposed to fix.