Cannot create links to new nodes after importing file

Question

Cannot create links to new nodes after importing file

nadescape opened this issue 4 years ago · comments

After importing a file (I tried both JSON and Twee2) you can no longer create a new node by adding a link to the body of an existing node. A node will be created, but it will be given the name Node# instead of the name in the link, and the widget to edit the existing node will refuse to close. Every attempt to close the widget will result in a new Node# being created. If you remove the link to the new node you will be able to close the edit widget. You can still create links to existing node, so creating a new node and then adding the link is a viable workaround.

David commented 4 years ago

I'm on it

nadescape · Answer 1 · Wed May 27 2020 09:34:07 GMT+0800 (China Standard Time)

As best I can tell, this issue was introduced on 4/23.

Todor Imreorov · Answer 2 · Wed May 27 2020 20:38:36 GMT+0800 (China Standard Time)

@daviddq can you have a look if one of the recent PRs broke this? :)
You did quite a lot of refactoring on that logic

Todor Imreorov · Answer 3 · Wed May 27 2020 21:46:01 GMT+0800 (China Standard Time)

Autocreating a new node is completely broken at the moment, the user will get stuck inside the node editor, while yarn keeps making new nodes with the wrong name 😭

David · Answer 4 · Wed May 27 2020 23:58:35 GMT+0800 (China Standard Time)

I pushed a fix. It seems to be a bug while disabling KnockOut rate limit extender.

Thanks a lot @nadescape for your accurate description of the issue.

nadescape · Answer 5 · Thu May 28 2020 00:35:11 GMT+0800 (China Standard Time)

thanks for the quick fix! :)