What is contributor workflow
ziloka opened this issue · comments
I'm not very experienced with python and I just did my first PR for this project. What is your developer workflow?
I usually just write my code, and run pip install . and test it.
hi @ziloka , basically just write code, test it, and ensure the result passes code quality checks and all the tests.
When a PR is created, some auto testing process will start, and other developers will help with code review.
Make sure you have all the information needed in the PR description section, including what problem(s) you're solving, a few sentences about how you did it, and what other things should be noted or aware of.
Just try to communicate, and everything will be all fine. :-)
I'd be nice to have you joined! 🚀
Thank you
Maybe we can remove requirements.txt and other files not necessary after (fully) use Poetry. This prevent contributors from taking wrong tool or outdated dependency.
For example, I notice the requirements.txt and I don't know Poetry. That will make me use pip install -r requirements.txt to install dependencies but those may outdated.
To reach this, update README (#85 ) and build a workflow depend on Poetry is indispensable.
@hms5232 sure why not. It'd be awesome.
I use this command in the root directory to test whatever I want.
poetry run python -m proxybroker [args.. options.. etc]eg
poetry run python -m proxybroker find --types HTTP HTTPS --lvl High --countries US --strict -l 10Sometimes when I want to more information to debug I'll run it with the logging on debug
poetry run python -m proxybroker --log DEBUG find --types HTTP HTTPS SOCKS4 SOCKS5 -l 10what command do you run to test the cli?
Here use pyenv, in combination of poetry
pyenv local 3.11.6
poetry install
# run whatever command
poetry run python -m proxybroker find --types HTTP HTTPS SOCKS4 SOCKS5 -l 10