Giters

bloomberg / xcdiff

A tool which helps you diff xcodeproj files.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Lenient comparison between empty and nil arrays in build phases

natanrolnik opened this issue · comments

commented

Describe the bug
When comparing build phases, I believe xcdiff could be more lenient when comparing the arrays of input files. For example, if one project's build phase has nil as inputFileListPaths or outputFileListPaths, and another project has an empty array, it triggers an error in the Build Phases section. Obviously, this is a diff, and if this is a bug or expected behavior is debatable. But in practical terms, they are identical.

To Reproduce
Steps to reproduce the behavior:

  1. Create an Xcode project manually with no inputFileListPaths
  2. Create another project generated by Tuist
  3. xcdiff between the two
  4. See the error below in the screenshot.

Expected behavior
A comparison between nil and empty array should not be considered an error.

Screenshots
EmptyVsNilBuildPhaseInput

Environment (please complete the following information):

  • macOS 10.15
commented

Good catch! Many thanks for reporting it @natanrolnik.

commented

Resolved by 95f413a. Many thanks @natanrolnik!