Giters

blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.

Home Page:https://blishhud.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bug: module doesnt get an api token when new module version requires new api permissions

Taschenbuch opened this issue · comments

commented

issue

this should not return empty permissions. instead it should disable the module until user enables it again to accept the new permissions.
https://github.com/blish-hud/Blish-HUD/blob/c13681832a494899ed6147bea48a7ea74b9bf890/Blish%20HUD/GameServices/Modules/Managers/Gw2ApiManager.cs#L59C51-L59C73

steps to reproduce:

I try to explain it better:

  1. User has added correct api key with all permissions possible for an api key
  2. user installs the module. The module is running fine.
  3. module gets a new version and the module requires new permissions now. e.g. "inventories" "unlocks"
  4. user sees that there is a module update and clicks on update. Update is successfull and module starts running again
  5. module is not able to access api because it gets no api token anymore. Even after blish restarts. User is confused why module is not working anymore. happy path: he will ask here. more realistic: he will uninstall the module after trying to fix it on his own and probably fail (because that is even hard for module devs to track down and fix this issue while developing the module).

discussion

About quick fix and possible future improvements of handling this situation:
https://discord.com/channels/531175899588984842/536970543736291346/1153722648438788166