Docker-compose default config uses invalid network subnet
roundowl opened this issue · comments
Greetings!
From the readme:
If you are interested about the status of this project, the easiest way to get Abstruse 2.x running is:
git clone https://github.com/bleenco/abstruse.git
cd abstruse
docker-compose -f configs/demo/default/docker-compose.yml up -d
However, running the above (with the exception of running through docker compose plugin) leads to:
$ docker compose -f configs/demo/default/docker-compose.yml up -d
[+] Running 17/17
✔ mysql 10 layers [⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿] 0B/0B Pulled 10.5s
✔ 558b7d69a2e5 Pull complete 1.5s
✔ 2cb5a921059e Pull complete 1.7s
✔ b85878fb9bb2 Pull complete 1.8s
✔ d16f3fd26a82 Pull complete 1.9s
✔ afd51b5329cb Pull complete 2.1s
✔ 374d2f7f3267 Pull complete 2.2s
✔ 4ea1bb2c9574 Pull complete 3.1s
✔ 1c9054053605 Pull complete 2.4s
✔ d79cd2da03be Pull complete 3.4s
✔ e3a1aa788d17 Pull complete 2.7s
✔ abstruse-server 3 layers [⣿⣿⣿] 0B/0B Pulled 3.8s
✔ c158987b0551 Pull complete 0.4s
✔ 3e54539a3613 Pull complete 0.6s
✔ 747633122caf Pull complete 1.7s
✔ abstruse-worker 1 layers [⣿] 0B/0B Pulled 3.6s
✔ 1ee9485349cd Pull complete 1.8s
[+] Running 1/0
✘ Network default_demo_net Error 0.0s
failed to create network default_demo_net: Error response from daemon: invalid network config:
invalid subnet 10.20.20.0/16: it should be 10.20.0.0/16
I propose replacing the 10.20.20.0/16 subnet with 10.20.20.0/24, since the default config only uses addresses 10, 20 and 30 in that network. With only this change, the demo setup runs successfully.
hi @roundowl, thanks for this warning, do you have time to open a PR with the fix?
Hi @jkuri, of course, here it is
I've briefly checked that I can clone this repo and run all three configs, but didn't (couldn't) run the complete testing environment.
thank you for the fix! I think testing env is deprecated and should be removed.