Zeal on linux is ignoring the first parameter (the query)

Question

Zeal on linux is ignoring the first parameter (the query)

sphaerophoria opened this issue 7 years ago · comments

it seems on linux the following will omit the first parameter when passed to zeal

xdg-open "dash-plugin:query=shared_ptr&keys=cpp,net,boost,qt,cvcpp,cocos2dx,c,manpages"

while the following works just fine

xdg-open "dash-plugin://query=shared_ptr&keys=cpp,net,boost,qt,cvcpp,cocos2dx,c,manpages"

According to https://kapeli.com/dash_plugins the dash-plugin format is dash-plugin://keys={keywords}&query={query} which matches my expectation for uri.

It seems in 137f5b3 you explicitly avoided this, but I'm not sure what the rational behind this was. Rolling back this change seems to fix the issue for me.

Zeal version 0.3.1
atom-dash 1.7.1

Oleg Shparber · Answer 1 · Thu Mar 16 2017 21:48:33 GMT+0800 (China Standard Time)

The change was made because of KDE being very strict about the URL format, and in this case // should not be there. Zeal should parse that just fine, I'll check that.

Oleg Shparber · Answer 2 · Mon Mar 20 2017 09:16:30 GMT+0800 (China Standard Time)

I have tried it, and both xdg-open commands work just fine, with or without double slashes.

It might be a problem specific to your setup. What are your system and desktop environment?

sphaerophoria · Answer 3 · Mon Mar 20 2017 09:51:27 GMT+0800 (China Standard Time)

Interesting! I'm just running a fairly default fedora 25 installation (Gnome 3). Not quite sure what else is releavant. xdg-open version 1.1.1+, zeal 0.3.1.

I can look a little farther into tracking down the source of the problem, I just thought it was an "easy fix" but clearly something more interesting is going on here. Thanks :).

Oleg Shparber · Answer 4 · Mon Mar 20 2017 09:55:25 GMT+0800 (China Standard Time)

Try running Zeal with the whole URI:

zeal "dash-plugin:query=shared_ptr&keys=cpp,net,boost,qt,cvcpp,cocos2dx,c,manpages"

sphaerophoria · Answer 5 · Mon Mar 20 2017 10:00:30 GMT+0800 (China Standard Time)

That works as expected.

Oleg Shparber · Answer 6 · Mon Mar 20 2017 10:11:04 GMT+0800 (China Standard Time)

So, the problem is somewhere between xdg-open and Zeal. Fedora uses .desktop file provided by us, so it should work just fine.

Also my xdg-open is slightly older, but I don't think that's the reason.

% xdg-open --version 
xdg-open 1.1.0 rc3

I am open to ideas :)

sphaerophoria · Answer 7 · Mon Mar 20 2017 10:12:37 GMT+0800 (China Standard Time)

I think I've tracked it down. Created a quick .desktop file to print out what it's receiving from xdg-open

└> xdg-open "dash-plugin:query=shared_ptr&keys=cpp,net,boost,qt,cvcpp,cocos2dx,c,manpages"
dash-plugin:///query=shared_ptr&keys=cpp,net,boost,qt,cvcpp,cocos2dx,c,manpages
└> xdg-open "dash-plugin://query=shared_ptr&keys=cpp,net,boost,qt,cvcpp,cocos2dx,c,manpages"
dash-plugin://query=shared_ptr&keys=cpp,net,boost,qt,cvcpp,cocos2dx,c,manpages/

Looks like xdg-open is introducing a third slash. When executing zeal with the third slash it doesn't correctly parse. Going to have to think about how to fix it but at least we have a cause :)

sphaerophoria · Answer 8 · Mon Mar 20 2017 10:29:54 GMT+0800 (China Standard Time)

Looks like it's a problem with gio. xdg-open has a bunch of logic to decide who he asks to open his uri for him. If I put a dummy gio in my path before the system gio it falls back on gvfs-open and it works as expected.

For the time being maybe we can launch zeal directly (maybe hidden by a package configuration parameter if that's undesirable behavior).

Oleg Shparber · Answer 9 · Mon Mar 20 2017 10:33:26 GMT+0800 (China Standard Time)

Fedora pulls in many of post 1.1.1 xdg-utils changes, that my Arch version doesn't have. GIO support is one of them. I guess it makes sense to file a bug report with xdg-utils and Fedora. Since that code hasn't been officially released yet, not too many users are affected.

sphaerophoria · Answer 10 · Mon Mar 20 2017 10:39:01 GMT+0800 (China Standard Time)

I think that's reasonable. A bug filed with gio is probably reasonable as well since it's the one actually mangling the URIs. I can hold local modifications of my package until that's resolved. I don't think there's anything to be done on your end as it's not your bug :). Thanks for the time!

Oleg Shparber · Answer 11 · Mon Mar 20 2017 10:40:13 GMT+0800 (China Standard Time)

No problem, thanks for debugging this.

Oleg Shparber · Answer 12 · Mon Mar 20 2017 10:41:00 GMT+0800 (China Standard Time)

When you file bug reports, please post links here, just for the reference.

‮zlohhcuB treboR · Answer 13 · Tue Apr 04 2017 22:58:06 GMT+0800 (China Standard Time)

@sphaerophoria did you end up opening a bug about this?

There is https://bugzilla.redhat.com/show_bug.cgi?id=1426299, but I am not certain that this is the same issue.

Benjamin Navarro · Answer 14 · Tue Oct 24 2017 22:13:02 GMT+0800 (China Standard Time)

Just to mention that I have the same problem on my setup (Archlinux, xdg-open v1.1.2). Adding the // solves the problem for me too

Oleg Shparber · Answer 15 · Wed Oct 25 2017 04:31:29 GMT+0800 (China Standard Time)

We removed // due to KDE problem, and xdg-open is supposed to handle such URLs properly. I wonder if skype: protocol works with the new xdg-utils...

Benjamin Navarro · Answer 16 · Wed Oct 25 2017 13:41:31 GMT+0800 (China Standard Time)

I've seen that but since it causes issues in other environment maybe an option on Linux to choose to have // or not might be beneficial. You can leave it disabled by default to keep the current behavior and allow users to enable it if they face this problem.

EDIT: I tried a call to xdg-open "mailto:me" and the to field in filled with ///me, looks like what has been seen in a previous comment