Giters

bjlittle / geovista

Cartographic rendering and mesh analytics powered by PyVista

Home Page:https://geovista.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Python 3.11 support

dennissergeev opened this issue · comments

commented

✨ Feature Request

Feel free to ignore this for now as this is a very minor issue, but it would be great to remove the Python version cap at 3.10. Or is there a specific reason you've capped it for now?

Motivation

Keeping up with the pace of Python 🐍

Additional Context

I actually tried geovista in a py-3.11 environment, and it seemed to work. I haven't done any extensive testing though.

commented

@dennissergeev Yup, top of my todo list👍

I was hitting issues with vtk on PyPI for the release, hence the temporary pin for now.

Thanks for raising this issue 🍻

commented

Great, thanks for the prompt response! 🚀

Love the new badge by the way!

status

commented

@dennissergeev The problem here is that due to an issue with vtk (PR #3869) when using pyvista, has forced me to temporarily rolled back from using the latest vtk 9.2.5 to 9.2.2.

Also, note that, vtk 9.2.2 landed back in Oct 2022, and as such no binary wheels were built for py311. See here.

So I'm kinda caught between a rock and a hard-place with regards to PyPI dependencies.

However, I'm going to relax the pin for vtk in the setup.cfg, so that the PyPI dependencies will resolve for py311, but users will hit issues, until they are fixed upstream. The workaround is simply to install geovista with conda instead 😉

This approach will allow me to remove the python pin in the setup.py, and support py311 with conda.

Works for me 👍

commented

@bjlittle this is brilliant, thanks very much!

One more thing: does pyvista still need to be pinned at 0.37? I'm asking because I'd like to use the latest version (0.38.1) with the new interactive backend - trame.

commented

@bjlittle this is brilliant, thanks very much!

One more thing: does pyvista still need to be pinned at 0.37? I'm asking because I'd like to use the latest version (0.38.1) with the new interactive backend - trame.

No worries 👍

Yeah, trame is super cool. Looking forward to using it as a backend too.

The are two reasons why pyvista is temporarily pinned ATM

  • pyvista 0.38.x introduced a massive performance hit (see pyvista/pyvista#3971), but I know the fix to address this
  • some colleagues at the Met Office are running a tutorial at the Bureau of Meteorology in Oz this week. The tutorial uses geovista and it would cause issues/extra work/stress to move to pyvista 0.38.x atm

So as a courtesy, I'm just holding/pinning back until the end of this week, the I'll unpin pyvista 👍

It's just a timing thing, so sorry for the inconvenience 🥹

commented

Ah that's totally fine. Thanks for the explanation 👍
I can certainly wait!