Error in line 203 of CookieMonster.php

Question

Error in line 203 of CookieMonster.php

meyergru opened this issue 8 years ago · comments

Dr. Uwe Meyer-Gruhl commented 8 years ago

When setting a cookie domain, there will be an error:

yii\base\ErrorException:2] exception 'yii\base\ErrorException' with message 'preg_match() expects at least 2 parameters, 1 given' in /home/xyz/vendor/bizley/cookiemonster/src/CookieMonster.php:203

This is correct, as preg_match must have 2 parameters at least. I believe the 2nd parameter should be $value.

Bizley commented 8 years ago

Thanks!

Dr. Uwe Meyer-Gruhl · Answer 1 · Wed May 11 2016 04:41:21 GMT+0800 (China Standard Time)

Great work. But by your refactoring of parameters from 'cookie' into 'content', the README.md becomes wrong, e.g. the "domain" parameter must be moved now.

Bizley · Answer 2 · Wed May 11 2016 05:47:42 GMT+0800 (China Standard Time)

I'm not sure what are you referring to. Could you elaborate?
I'm pretty sure I have not moved parameters...

Dr. Uwe Meyer-Gruhl · Answer 3 · Wed May 11 2016 06:05:02 GMT+0800 (China Standard Time)

+1, you are right. I just looked at the diff and saw domain now below 'content', but the @vars are above the sections... all is fine now. Thanks!