Docker image issues
abitmore opened this issue · comments
Description
As of writing, we use phusion/baseimage:focal-1.2.0 (code) as the base image of our Docker image.
Issues:
- The
phusion/baseimage:focal-1.2.0
Docker image on Docker Hub was pushed a year ago and has not been updated since. There are newjammy-*
images, but so far we do not support Ubuntu Jammy. Although we doapt-get upgrade
when building and running our own images, these commands bloat the image. Ideally the base image should be updated regularly when there are updates to its own base image or packages, even if there are no code changes in itself (also see #2667). - The
phusion
base image comes preinstalled with some utilities and services that we don't really need, which bloat the image and potentially introduce vulnerabilities. We can doapt-get remove
when building our own images, but this will not reduce our image size.
Nevertheless, we don't want to simply change our base image to ubuntu:20.04
, because the phusion
base image does have a lot of good stuff.
Potential solutions:
- Ask the maintainers of
phusion/baseimage
to regularly update the images on Docker Hub. - Fork
phusion/baseimage
and maintain our own base image (both code and image). For example, take a look at phusion/baseimage-docker@master...HydroMoon:laravel-baseimage:master, https://github.com/cyledge/baseimage-docker and https://github.com/phusion/baseimage-docker/network. - Port the code in
phusion/baseimage
into our repository directly (and maintain it), so that we can change our base image toubuntu:20.04
.
Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.
- API (the application programming interface)
- Build (the build process or something prior to compiled code)
- CLI (the command line wallet)
- Deployment (the deployment process after building such as Docker, Travis, etc.)
- DEX (the Decentralized EXchange, market engine, etc.)
- P2P (the peer-to-peer network for transaction/block propagation)
- Performance (system or user efficiency, etc.)
- Protocol (the blockchain logic, consensus, validation, etc.)
- Security (the security of system or user data, etc.)
- UX (the User Experience)
- Other (please add below)
CORE TEAM TASK LIST
- Evaluate / Prioritize Bug Report
- Refine User Stories / Requirements
- Define Test Cases
- Design / Develop Solution
- Perform QA/Testing
- Update Documentation