Incomplete and broken move of metrics to isolated port
bootc opened this issue · comments
Which component:
controller 0.24.5
Describe the bug
#1369 is a major change to how metrics are exposed in sealed-secrets, and the MR only partially updates the Helm chart to account for the changes. Anyone relying on scraping metrics from Sealed Secrets on port 8080 will see breakage, and anyone using the ServiceMonitor bundled with the Helm chart will also get a nasty surprise.
To Reproduce
Install Sealed Secrets. In version 0.24.4 and below the metrics are available on port 8080; in 0.24.5 they are only available on port 8081.
Using the Helm chart, the ServiceMonitor detects both of the sealed-secrets Service resources and attempts to scrape both. The sealed-service-metrics Service definition is broken and metrics are not available via that service. As a result, no metrics are collected at all from either Service.
Expected behavior
Metrics should work. Major breaking changes should not be introduced in a patch release.
Version of Kubernetes:
- Output of
kubectl version:
Client Version: v1.29.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.4+rke2r1