bitnami-labs / sealed-secrets

The documentation for the commonAnnotations value says "Annotations to add to all deployed resources":

sealed-secrets/helm/sealed-secrets/values.yaml

Line 19 in 5b0c26e

    
           ## @param commonAnnotations [object] Annotations to add to all deployed resources

Yet, not all resources have annotations at all, let alone the common annotations:

sealed-secrets/helm/sealed-secrets/templates/cluster-role-binding.yaml

Lines 4 to 9 in 5b0c26e

    
           metadata: 
        
             name: {{ include "sealed-secrets.fullname" . }} 
        
             labels: {{- include "sealed-secrets.labels" . | nindent 4 }} 
        
               {{- if .Values.rbac.labels }} 
        
               {{- include "sealed-secrets.render" ( dict "value" .Values.rbac.labels "context" $) | nindent 4 }} 
        
               {{- end }}

I suggest we implement commonAnnotations to work as documented. Depending on the circumstances, it might be good to implement it via a template in _helpers.tpl and reference that instead.

	metadata:
	name: {{ include "sealed-secrets.fullname" . }}
	labels: {{- include "sealed-secrets.labels" . \| nindent 4 }}
	{{- if .Values.rbac.labels }}
	{{- include "sealed-secrets.render" ( dict "value" .Values.rbac.labels "context" $) \| nindent 4 }}
	{{- end }}

`commonAnnotations` are not implemented for all resources