[bug] The new Algo.Orders panel shows AO that are not running (+bad count)
pointops opened this issue · comments
3.31.3 Stable (development mode, live, no sandbox)
a) launch successfully 'sell' P-P with 40 slices
b) fail to launch 'buy' P-P with 30 slices - insufficient balance (500 XRP each)
c) launch successfully 'buy' P-P with 30 slices at half value (250 XRP each)
Problem:
the B) AO which correctly did not start:
- is displayed in the Algo.Orders modal (shouldn't be)
- increases the AO count in the Tradidig State Panel (wrongly)
- cannot be killed (which is correct because it ain't running)
Request:
The new Algo.Orders panel should implement a validity check for AOs being displayed, the same as the previous version did. AOs not running should not be listed.
Apparently, this will also fix the counter (from 3 to 2 in the example above) in Trading State panel, as that value for the indication may be taken from the Algo.Orders panel (is it? strange choice..)
Can't reproduce immediately, definitely shouldn't be there if it wasn't running. Nevertheless, it's under review... could be a signal of a more insidious issue.
@pointops if you restart an app, does this AO appear in Resume modal?
Nope, it did not. Very good call.
But tested only once. Probably I need to wait until the second week of March (31.4) for more controlled research.
I tried to reproduce this issue but failed.
- Submitting sell P/P AO with 40 slices: success.
- Submitting buy P/P AO with 20 slices: failure due to not enough balance.
- Submitting buy P/P AO with 20 slices with lower amount of money: success.
Created orders details:
In all of the requests the frontend part sent the exact data user input into the order form and rendered the orders backend sent to it correctly, the backend side also seems to work properly by either creating the order or throwing an error.
@pointops did I try to reproduce the error correctly or should I change something in here?
Just noticed that on the screenshots I tried 20 slices instead of 30 as described above, but I tested 30 slices as well - still not able to reproduce.
Hi. Your sequence seems the same as mine.
Unintentionally I missed this ticket during my review 2 days ago. Please stand-by for me to try and reproduce it - on 3.31.4.
From what you post, it is no longer happening.
Stale issue message