bitcoinjs / bolt11

A library for encoding and decoding lightning network payment requests as defined in BOLT #11.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support Satoshis only [for now]

dcousens opened this issue · comments

On a discussion with @Roasbeef, the suggestion was that msats will be too confusing in the short term, and

I don't really see msat being used for anything, at least in the short term

and

lnd always display sat, and accepts sat (on the rpc layer)

I propose, until the use cases come out, we temporarily drop the support and deal only in satoshis.

Thoughts @junderw ?

I agree. I have reverted to handling satoshis on wip branch

I am using this great little library in a lightning wallet I'm developing but have noticed some merchants (eg. Blockstream store) are now encoding invoices in msats.

Could decoding support for millisatoshis be added?
Currently invoices with a 'p' divisor fail saying "Amount is outside of valid range"

@jordodev could you make a new issue please? Also provide any names of services already using mSats. Thanks.