millisatoshis is a string?

Question

millisatoshis is a string?

nicolasburtey opened this issue 4 years ago · comments

nicolasburtey commented 4 years ago

satoshis is returned as a number
millisatoshis as a string

Is that intended? Because of javascript issue with big numbers?

Jonathan Underwood · Answer 1 · Thu Apr 23 2020 07:23:18 GMT+0800 (China Standard Time)

Yes.

Other libraries tend to use their favorite big number library as output, but that can cause problems with other apps where people who don't want to use OUR big number library do things like new TheirBigNumLib(millisats.toString(10), 10)

BigInt is finally supported in JavaScript, but everyone wants to support IE8 for all eternity, so any time a library uses anything modern they are yelled at.

This was a balance we struck.

If you have a better idea, we're open to discussing it / reviewing Pull Requests.

nicolasburtey · Answer 2 · Thu Apr 23 2020 07:28:30 GMT+0800 (China Standard Time)

ok make sense. don't have a better idea but at least I understand what that is