bitcoin-core / ctaes

Simple constant-time AES implementation

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

signed overflow on 16bit

tankf33der opened this issue · comments

commented

FYI.

I have setup demo repo to run ctaes tests under TIS-CI.

Report of test run you can find here and check "undefined behaviour" in list for 16bit platforms.

Known members of TIS team in github are: @pascal-cuoq and @guillaumemillot

@tankf33der Thanks for analyzing this. Could you see if #18 fixes this?

commented

@tankf33der Thanks for analyzing this. Could you see if #18 fixes this?

@sipa, LoadByte function fixed and now TIS found next one. I could somehow enable option "dont stop after first alarm and keep running", but lets do it one by one.

commented

@sipa

All green, issue closed.

Awesome, thanks!