bitcoin-core / btcdeb

Bitcoin Script Debugger

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Argument type warnings on ubuntu 18.04

jan-kwiatkowski opened this issue · comments

  CXX      test/test_btcdeb-utils.o
  CXX      test/test_btcdeb-value.o
  CXXLD    test-btcdeb
  CXX      tap-instance.o
  CXX      tap-functions.o
  CXX      tap-tap.o
tap.cpp: In function ‘int main(int, char* const*)’:
tap.cpp:25:47: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 3 has type ‘int64_t {aka long int}’ [-Wformat=]
 #define abort(msg...) do { fprintf(stderr, msg); fputc('\n', stderr); exit(1); } while(0)
                                               ^
tap.cpp:371:111:
             abort("pubkey mismatch: input transaction's vout[%lld].scriptPubKey = %s, but our pubkey = %s\n", instance.txin_vout_index, HEXC(spk), HE
XC(serialized_pk));
                                                                                                               ~~~~~~~~~~
tap.cpp:371:13: note: in expansion of macro ‘abort’
             abort("pubkey mismatch: input transaction's vout[%lld].scriptPubKey = %s, but our pubkey = %s\n", instance.txin_vout_index, HEXC(spk), HE
XC(serialized_pk));
             ^~~~~
tap.cpp:25:47: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 3 has type ‘int64_t {aka long int}’ [-Wformat=]
 #define abort(msg...) do { fprintf(stderr, msg); fputc('\n', stderr); exit(1); } while(0)
                                               ^
tap.cpp:375:125:
             abort("pubkey mismatch: input transaction's vout[%lld].scriptPubKey %s does not end (%s) with our pubkey %s\n", instance.txin_vout_index,
 HEXC(spk), HEXC(cmp), HEXC(serialized_pk));
                                                                                                                             ~~~~~~~~~~
tap.cpp:375:13: note: in expansion of macro ‘abort’
             abort("pubkey mismatch: input transaction's vout[%lld].scriptPubKey %s does not end (%s) with our pubkey %s\n", instance.txin_vout_index$
 HEXC(spk), HEXC(cmp), HEXC(serialized_pk));
             ^~~~~
  CXXLD    tap

Those are warnings, not errors, so the compile should have succeeded. Will look into using the print-format-macros to get rid of them though.

This should be fixed in latest master. Let me know if you still see warnings and I'll reopen.