check-dnsseeds hangs on MacOS

Question

check-dnsseeds hangs on MacOS

laanwj opened this issue 3 years ago · comments

katesalazar · Answer 1 · Wed Jan 26 2022 18:06:08 GMT+0800 (China Standard Time)

$ ./check-dnsseeds.py 
* Mainnet
OK   seed.bitcoin.sipa.be (39 results)
OK   dnsseed.bluematt.me (31 results)
OK   dnsseed.bitcoin.dashjr.org (36 results)
OK   seed.bitcoinstats.com (37 results)
OK   seed.bitcoin.jonasschnelli.ch (37 results)
OK   seed.btc.petertodd.org (37 results)
OK   seed.bitcoin.sprovoost.nl (36 results)
OK   dnsseed.emzy.de (29 results)
OK   seed.bitcoin.wiz.biz (31 results)

* Testnet
OK   testnet-seed.bitcoin.jonasschnelli.ch (23 results)
OK   seed.tbtc.petertodd.org (38 results)
OK   testnet-seed.bluematt.me (6 results)
OK   seed.testnet.bitcoin.sprovoost.nl (34 results)
$ vim check-dnsseeds.py
$ git diff
diff --git a/check-dnsseeds.py b/check-dnsseeds.py
index 32b6ef1..700dd19 100755
--- a/check-dnsseeds.py
+++ b/check-dnsseeds.py
@@ -7,7 +7,7 @@ import subprocess
 
 SEEDS_MAINNET=["seed.bitcoin.sipa.be","dnsseed.bluematt.me","dnsseed.bitcoin.dashjr.org",
         "seed.bitcoinstats.com","seed.bitcoin.jonasschnelli.ch","seed.btc.petertodd.org",
-        "seed.bitcoin.sprovoost.nl", "dnsseed.emzy.de","seed.bitcoin.wiz.biz"]
+        "seed.bitcoin.sprovoost.ne", "dnsseed.emzy.de","seed.bitcoin.wiz.biz"]
 SEEDS_TESTNET=["testnet-seed.bitcoin.jonasschnelli.ch","seed.tbtc.petertodd.org",
         "testnet-seed.bluematt.me","seed.testnet.bitcoin.sprovoost.nl"]

$ ./check-dnsseeds.py 
* Mainnet
OK   seed.bitcoin.sipa.be (39 results)
OK   dnsseed.bluematt.me (31 results)
OK   dnsseed.bitcoin.dashjr.org (36 results)
OK   seed.bitcoinstats.com (37 results)
OK   seed.bitcoin.jonasschnelli.ch (37 results)
OK   seed.btc.petertodd.org (37 results)
FAIL seed.bitcoin.sprovoost.ne
OK   dnsseed.emzy.de (29 results)
OK   seed.bitcoin.wiz.biz (31 results)

* Testnet
OK   testnet-seed.bitcoin.jonasschnelli.ch (23 results)
OK   seed.tbtc.petertodd.org (38 results)
OK   testnet-seed.bluematt.me (6 results)
OK   seed.testnet.bitcoin.sprovoost.nl (34 results)
$ echo $?
0
$ uname -a
Darwin HOSTNAME 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:54 PST 2021; root:xnu-8019.61.5~1/RELEASE_X86_64 x86_64
$ sw_vers
ProductName:    macOS
ProductVersion: 12.1
BuildVersion:   21C52
$

edited: removed host name

ugh yeah wrote this on an obsolete default branch
replayed everything on the new default branch, to same results

katesalazar · Answer 2 · Wed Jan 26 2022 18:13:21 GMT+0800 (China Standard Time)

check-dnsseeds questionably exits 0 even if no seed is reachable

laanwj · Answer 3 · Wed Mar 02 2022 01:18:49 GMT+0800 (China Standard Time)

check-dnsseeds questionably exits 0 even if no seed is reachable

Yes, i've never really used its exit status. There's no standard way to report "it's mostly OK" exit status. Could define a convention and document it, but I'm not sure anyone is using this script in any kind of programmatic monitoring way.

laanwj · Answer 4 · Wed Mar 02 2022 01:21:12 GMT+0800 (China Standard Time)

As for on topic, we might want to use Python module dns.resolver (as also used by makeseeds.py) instead of calling out to host at some point. This introduces a dependency, but removes the impact of platform specific tool difference.

katesalazar · Answer 5 · Wed Mar 02 2022 04:54:43 GMT+0800 (China Standard Time)

How about this as an initial spec? - no seed failed: return 0 - any seed failed: return a random number, but do not return 0

…

On Tue, Mar 1, 2022 at 6:19 PM laanwj ***@***.***> wrote: check-dnsseeds questionably exits 0 even if no seed is reachable Yes, i've never really used its exit status. There's no standard way to report "it's mostly OK" exit status. Could define a convention and document it, but I'm not sure anyone is using this script in any kind of programmatic monitoring way. — Reply to this email directly, view it on GitHub <#117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMRS4WY4S6ZCK2ZHZ2T4OWLU5ZGQLANCNFSM5EWEQOYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

katesalazar · Answer 6 · Wed Mar 02 2022 05:46:24 GMT+0800 (China Standard Time)

no, better have them parsing the output
sorry for the noise

katesalazar · Answer 7 · Thu Mar 10 2022 07:35:09 GMT+0800 (China Standard Time)

no, better have them parsing the output
sorry for the noise

$ ./check-dnsseeds.py | \
            sed 's/\x1B\[[0-9;]\{1,\}[A-Za-z]//g' | \
            awk 'BEGIN {sum_ok=0; sum_fail=0} {if ($1 == "OK") sum_ok += 1; if ($1 == "FAIL") sum_fail += 1} END {print "OK: ", sum_ok, "\nFAIL: ", sum_fail}'
OK:  14 
FAIL:  0
$

katesalazar · Answer 8 · Thu Mar 10 2022 07:41:21 GMT+0800 (China Standard Time)

back on topic: this does not really hang, does it?
can close...

... or rename to "remove host for Python module dns.resolver".

My host is not under a .../local/... dir, I don't think my system is affected of package manager taint for this command.

laanwj · Answer 9 · Thu Apr 14 2022 13:57:21 GMT+0800 (China Standard Time)

if @Sjors can verify it's no longer hanging we can close this.

Sjors Provoost · Answer 10 · Thu Apr 14 2022 21:54:18 GMT+0800 (China Standard Time)

Took only a few seconds on macOS 12.3.1 with using the latest main branch, on two different machines (Python 3.9.10 and 3.10.0).

% ./check-dnsseeds.py
* mainnet
OK   seed.bitcoin.sipa.be (39 results)
OK   dnsseed.bluematt.me (31 results)
OK   dnsseed.bitcoin.dashjr.org (36 results)
OK   seed.bitcoinstats.com (37 results)
OK   seed.bitcoin.jonasschnelli.ch (37 results)
OK   seed.btc.petertodd.org (37 results)
OK   seed.bitcoin.sprovoost.nl (36 results)
OK   dnsseed.emzy.de (31 results)
OK   seed.bitcoin.wiz.biz (31 results)

* testnet
OK   testnet-seed.bitcoin.jonasschnelli.ch (23 results)
OK   seed.tbtc.petertodd.org (38 results)
OK   testnet-seed.bluematt.me (6 results)
OK   seed.testnet.bitcoin.sprovoost.nl (34 results)

* signet
OK   seed.signet.bitcoin.sprovoost.nl (15 results)

Sjors Provoost · Answer 11 · Thu Apr 14 2022 21:57:05 GMT+0800 (China Standard Time)

P.S. it should probably explicitly check reachability via IPv4 and IPv6 as well whether it returns both IPv4 and IPv6 entries. But don't fail if one is missing, as I'm not sure all seeds support IPv6 reachability, and not everyone running this script will have IPv6 access.

laanwj · Answer 12 · Fri Apr 15 2022 01:01:02 GMT+0800 (China Standard Time)

Thanks for testing. Closing.
Sounds like a good feature to have when using a more fully-featured DNS lookup library. Might want to open a new issue for that 😄