bitbucket-rest-api / bitbucket

BitBucket API gem - bitbucket_rest_api

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Faraday 0.9.x?

simo2409 opened this issue · comments

This gem currently requires faraday ~> 0.8.1, is there any known problem using it with faraday's 0.9.x?

No known problems, but I also haven't tested it. I haven't had the resources to commit in a while.

I wanted to try to update dependency but I didn't find a way to run tests, reading Readme I tried with "rake" but it didn't work

Unfortunately, there aren't any actual tests written. I never got around to it. But, I'd be more than happy to accept any pull requests

That's why I couldn't find a way to run them :)

Thank you

I think there is a problem updating to faraday 0.9.0 due faraday_middleware which requires
faraday (>= 0.7.4, < 0.9)

There is a pull request which should make faraday_middleware to work with faraday 0.9.0 but until it will get accepted I couldn't find a way to fix it (.gemspec doesn't allow to specify :git in add_dependency)

Looks like that pull request breaks their tests too :/ so it could be a while.

Fixed with last accepted pull