Add memory leak testing with leakage

Question

Add memory leak testing with leakage

bitjson opened this issue 6 years ago · comments

Jason Dreyzehner commented 6 years ago

After andywer/leakage#27 lands

Jonathan Underwood · Answer 1 · Tue Jun 05 2018 15:39:41 GMT+0800 (China Standard Time)

It was merged.

Jason Dreyzehner · Answer 2 · Tue Jun 05 2018 23:06:08 GMT+0800 (China Standard Time)

After a little more consideration here, I don't think it's relevant for this library.

Since the exposed functionality is all written in a purely-functional style, and linting is preventing us from inadvertently bloating the global namespace or modifying built-in features, there really should be no way for this library to (itself) leak memory. The real leaks are going to happen downstream in consumers, if anywhere. (If you're using TypeScript and modern tooling, it's still unlikely.)

If anyone finds this in the future, I'd probably accept a PR that adds a separate test:leakage script like the bench script, but I'm going to close this for now.