bisq-network / bisq

A decentralized bitcoin exchange network

Home Page:https://bisq.network

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cannot provide XMR tx id and tx key with RPC method ConfirmPaymentStarted

dutu opened this issue · comments

commented

Description

When using RPC method ConfirmPaymentStarted for XMR trades, user is not able to provide transaction id and transaction key.

Version

v1.9.14

Steps to reproduce

RPC method ConfirmPaymentStarted() takes only one parameter (the trade_id).

Expected behaviour

ConfirmPaymentStarted() should allow two additional (optional) parameters for transaction id and transaction key, tx_id (ortx_hash) and tx_key.
This would be consistent with how GUI works and improve user experience.

Actual behaviour

API user cannot provide transaction id and transaction key with RPC method ConfirmPaymentStarted()

Device or machine

Debian, Bisq v1.9.14

Adding XMR parameters to ConfirmPaymentStarted() API method would

  • confuse users buying with non-XMR instruments (e.g. USD, EUR, or ETH)
  • break compatibility with existing clients

I propose adding a specific method ConfirmPaymentStartedXmr(tx_id, tx_key) to avoid the above issues.