birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.

Home Page:https://addons.mozilla.org/firefox/addon/10ten-ja-reader/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

We shouldn't lookup words when tapping a text box

birtles opened this issue · comments

On mobile, we allow taps to lookup words without having to use the puck. However, we take care to avoid doing lookups on buttons and links.

We should extend that to text boxes too. It's annoying when you tap a text box with Japanese text in order to focus it and we end up showing the popup for the text under the tap.

Presumably we'll need to ensure we cover contenteditable elements too.

I might try my hand at this once #1653 is merged, if you don't care. I'm all for improving the experience on mobile.

By all means go for it! Thank you!