💅 useExhaustiveDependencies complains about not including React component in dependency array
wojtekmaj opened this issue · comments
Environment information
CLI:
Version: 1.8.0
Color support: true
Platform:
CPU Architecture: aarch64
OS: macos
Environment:
BIOME_LOG_DIR: unset
NO_COLOR: unset
TERM: "xterm-256color"
JS_RUNTIME_VERSION: "v22.0.0"
JS_RUNTIME_NAME: "node"
NODE_PACKAGE_MANAGER: "yarn/4.1.1"
Biome Configuration:
Status: Loaded successfully
Formatter disabled: false
Linter disabled: false
Organize imports disabled: false
VCS disabled: true
Linter:
JavaScript enabled: true
JSON enabled: true
CSS enabled: false
Recommended: false
All: false
Enabled rules:
performance/noDelete
suspicious/noCatchAssign
suspicious/noUnsafeNegation
complexity/useLiteralKeys
style/useImportType
complexity/noMultipleSpacesInRegularExpressionLiterals
a11y/useValidLang
complexity/noUselessEmptyExport
suspicious/useNamespaceKeyword
suspicious/useValidTypeof
a11y/useValidAriaRole
correctness/noConstantCondition
a11y/useAriaActivedescendantWithTabindex
suspicious/noAssignInExpressions
style/useDefaultParameterLast
complexity/noEmptyTypeParameters
correctness/noConstructorReturn
style/useSelfClosingElements
suspicious/noDuplicateParameters
style/useTemplate
correctness/noUnusedLabels
complexity/noUselessTernary
correctness/noUnreachableSuper
suspicious/noCompareNegZero
suspicious/noExplicitAny
correctness/noSwitchDeclarations
a11y/noAutofocus
correctness/noUnsafeOptionalChaining
correctness/noConstAssign
suspicious/noControlCharactersInRegex
complexity/noUselessTypeConstraint
style/noVar
suspicious/noDoubleEquals
suspicious/noRedundantUseStrict
style/useLiteralEnumMembers
suspicious/noGlobalIsNan
suspicious/noEmptyInterface
suspicious/noConstEnum
suspicious/noMisleadingCharacterClass
correctness/noPrecisionLoss
suspicious/noRedeclare
correctness/noStringCaseMismatch
correctness/noSetterReturn
correctness/noInvalidConstructorSuper
suspicious/noImplicitAnyLet
suspicious/noFallthroughSwitchClause
suspicious/noUnsafeDeclarationMerging
correctness/noUnreachable
a11y/useKeyWithClickEvents
suspicious/noDuplicateObjectKeys
complexity/noUselessThisAlias
complexity/noThisInStatic
complexity/useOptionalChain
correctness/noInnerDeclarations
style/noParameterAssign
suspicious/noDuplicateCase
a11y/useValidAnchor
complexity/useRegexLiterals
correctness/noSelfAssign
style/noUselessElse
style/useShorthandFunctionType
suspicious/noShadowRestrictedNames
a11y/useMediaCaption
complexity/noUselessLabel
complexity/noUselessCatch
correctness/noUnsafeFinally
a11y/useAriaPropsForRole
correctness/noNonoctalDecimalEscape
style/useEnumInitializers
a11y/useHtmlLang
suspicious/noDuplicateTestHooks
complexity/noStaticOnlyClass
style/useWhile
complexity/useArrowFunction
style/noInferrableTypes
a11y/noNoninteractiveTabindex
complexity/useSimpleNumberKeys
correctness/useYield
a11y/noInteractiveElementToNoninteractiveRole
style/useNumericLiterals
correctness/noUnnecessaryContinue
suspicious/noApproximativeNumericConstant
suspicious/noImportAssign
suspicious/noLabelVar
correctness/noGlobalObjectCalls
suspicious/useDefaultSwitchClauseLast
a11y/useAltText
correctness/noEmptyCharacterClassInRegex
suspicious/noSuspiciousSemicolonInJsx
suspicious/noSparseArray
a11y/useIframeTitle
complexity/noBannedTypes
a11y/noSvgWithoutTitle
correctness/noVoidElementsWithChildren
style/useAsConstAssertion
correctness/useJsxKeyInIterable
style/useExportType
complexity/noUselessLoneBlockStatements
style/noArguments
a11y/useValidAriaValues
suspicious/noDebugger
suspicious/noMisleadingInstantiator
suspicious/noPrototypeBuiltins
suspicious/noGlobalAssign
suspicious/noCommentText
suspicious/noDuplicateJsxProps
suspicious/noThenProperty
a11y/noPositiveTabindex
correctness/noEmptyPattern
complexity/noExcessiveNestedTestSuites
security/noDangerouslySetInnerHtmlWithChildren
a11y/useKeyWithMouseEvents
suspicious/noExtraNonNullAssertion
suspicious/useGetterReturn
correctness/noRenderReturnValue
correctness/useExhaustiveDependencies
security/noGlobalEval
style/noNonNullAssertion
a11y/noRedundantRoles
complexity/useFlatMap
correctness/useIsNan
style/useConst
suspicious/noGlobalIsFinite
suspicious/noSelfCompare
suspicious/noAsyncPromiseExecutor
security/noDangerouslySetInnerHtml
style/useNodejsImportProtocol
a11y/noDistractingElements
suspicious/noArrayIndexKey
complexity/noWith
suspicious/noDuplicateClassMembers
complexity/noExtraBooleanCast
performance/noAccumulatingSpread
a11y/useValidAriaProps
a11y/noRedundantAlt
correctness/noChildrenProp
suspicious/noConfusingLabels
suspicious/noConfusingVoidType
suspicious/noFocusedTests
a11y/useButtonType
a11y/noAriaUnsupportedElements
correctness/noFlatMapIdentity
a11y/noBlankTarget
a11y/useHeadingContent
correctness/useValidForDirection
correctness/noVoidTypeReturn
correctness/noInvalidUseBeforeDeclaration
a11y/noAriaHiddenOnFocusable
a11y/useAnchorContent
complexity/noUselessRename
correctness/noInvalidNewBuiltin
style/useNumberNamespace
complexity/noUselessConstructor
a11y/noAccessKey
style/useExponentiationOperator
style/noUnusedTemplateLiteral
style/useSingleVarDeclarator
suspicious/noExportsInTest
a11y/noNoninteractiveElementToInteractiveRole
style/noCommaOperator
suspicious/noConsoleLog
suspicious/useIsArray
a11y/noHeaderScope
complexity/noUselessFragments
suspicious/noMisrefactoredShorthandAssign
complexity/noForEach
suspicious/noClassAssign
suspicious/noFunctionAssign
Workspace:
Open Documents: 0Rule name
lint/correctness/useExhaustiveDependencies
Playground link
Expected result
MyRecursiveList should not be required to be placed inside dependency array, because it's not something that can dynamically change between renders, similarly to when we use another component: https://biomejs.dev/playground/?code=aQBtAHAAbwByAHQAIAB7ACAAdQBzAGUATQBlAG0AbwAgAH0AIABmAHIAbwBtACAAIgByAGUAYQBjAHQAIgA7AAoACgB0AHkAcABlACAATgBvAGQAZQAgAD0AIAB7AAoACQBpAGQAOgAgAG4AdQBtAGIAZQByADsACgAJAG4AbwBkAGUAcwA%2FADoAIABOAG8AZABlAFsAXQA7AAoAfQA7AAoACgBmAHUAbgBjAHQAaQBvAG4AIABNAHkAQQBuAG8AdABoAGUAcgBDAG8AbQBwAG8AbgBlAG4AdAAoACkAIAB7AH0ACgAKAGUAeABwAG8AcgB0ACAAZABlAGYAYQB1AGwAdAAgAGYAdQBuAGMAdABpAG8AbgAgAE0AeQBSAGUAYwB1AHIAcwBpAHYAZQBMAGkAcwB0ACgAewAgAG4AbwBkAGUAIAB9ADoAIAB7ACAAbgBvAGQAZQA6ACAATgBvAGQAZQAgAH0AKQAgAHsACgAJAGMAbwBuAHMAdAAgAGMAaABpAGwAZAByAGUAbgAgAD0AIAB1AHMAZQBNAGUAbQBvACgACgAJAAkAKAApACAAPQA%2BAAoACQAJAAkAbgBvAGQAZQAuAG4AbwBkAGUAcwA%2FAC4AbQBhAHAAKAAoAGMAaABpAGwAZAApACAAPQA%2BACAAKAAKAAkACQAJAAkAPABNAHkAQQBuAG8AdABoAGUAcgBDAG8AbQBwAG8AbgBlAG4AdAAgAGsAZQB5AD0AewBjAGgAaQBsAGQALgBpAGQAfQAgAG4AbwBkAGUAPQB7AGMAaABpAGwAZAB9ACAALwA%2BAAoACQAJAAkAKQApACwACgAJAAkAWwBuAG8AZABlAF0ALAAKAAkAKQA7AAoACgAJAHIAZQB0AHUAcgBuACAAPABkAGkAdgA%2BAHsAYwBoAGkAbABkAHIAZQBuAH0APAAvAGQAaQB2AD4AOwAKAH0ACgA%3D
Code of Conduct
- I agree to follow Biome's Code of Conduct