Giters

biologist79 / ESPuino

RFID-controlled musicplayer powered by ESP32

Home Page:https://forum.espuino.de

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Button 3 without rotary

GeneralLuzi opened this issue · comments

commented

Hi,

if rotary is disabled, there is no chance to use button_3 aka ROTARYENCODER_BUTTON.

I suggest, to exclude ROTARYENCODER_BUTTON from the USEROTARY_ENABLE section and change the other code parts allowing ROTARYENCODER_BUTTON to be used as a normal button without having a rotary.

// Rotary encoder
    #ifdef USEROTARY_ENABLE
        #define ROTARYENCODER_CLK           34          // If you want to reverse encoder's direction, just switch GPIOs of CLK with DT (in software or hardware)
        #define ROTARYENCODER_DT            39          // 39 = 'VN'; rotary's encoder 
    #endif

    // Amp enable (optional)
    #define GPIO_PA_EN                      108         // To enable/disable amp for loudspeaker; connected to port-expander

    // Control-buttons
    #define NEXT_BUTTON                     102         // Next-Button: connected to port-expander
    #define PREVIOUS_BUTTON                 100         // Prev-Button: connected to port-expander
    #define PAUSEPLAY_BUTTON                101         // Pplay-Button: connected to port-expander
----------new---------
    #define ROTARYENCODER_BUTTON        103         // Set to 99 to disable the button; connected to port-expander
-------------------------
    #define BUTTON_4                        104         // Button 4: connected to port-expander
    #define BUTTON_5                        105         // Button 5: connected to port-expander

Thanks for consideration.

Best regrads,
GL

commented

Technically you're right. But anyway I'm not sure if I really want to change this. Will give it a thought.

commented

Changed according your wishes (finally, hehe).