MQTT: new brightness values not published

Question

MQTT: new brightness values not published

GeneralLuzi opened this issue 3 years ago · comments

GeneralLuzi commented 3 years ago

Hi,

while setting a new value for the loudness is working fine, brightness does not work properly IMHO.

Use Case for loudness:

ESPUINO_MQTT publishes on start e.g. 10.
PRIVATE_MQTT_CLIENT receives 10
PRIVATE_MQTT_CLIENT publishes 11
ESPUINO_MQTT receives 11 and espuino sets loudness to 11
ESPUINO_MQTT publishes 11
PRIVATE_MQTT_CLIENT receives 11

Use Case for brightness:

ESPUINO_MQTT publishes on start e.g. 10.
PRIVATE_MQTT_CLIENT receives 10
PRIVATE_MQTT_CLIENT publishes 11
ESPUINO_MQTT receives 11 and espuino sets brightness to 11
-- NOT WORKING BELOW THIS LINE --
ESPUINO_MQTT publishes 11
PRIVATE_MQTT_CLIENT receives 11

Thanks and regards,
GL

GeneralLuzi · Answer 1 · Mon Nov 22 2021 04:05:41 GMT+0800 (China Standard Time)

Same on:

topicLockControlsCmnd
Cmnd/ESPuino/SleepTimer

biologist79 · Answer 2 · Mon Nov 22 2021 04:07:12 GMT+0800 (China Standard Time)

Need to investigate.

Benjamin Stürmer · Answer 3 · Tue Nov 23 2021 01:38:03 GMT+0800 (China Standard Time)

I discovered the same issue today. Fix can be found here: #124

GeneralLuzi · Answer 4 · Tue Nov 23 2021 02:32:20 GMT+0800 (China Standard Time)

If you need a tester feel free to ask! :)Von: Benjamin Stürmer ***@***.***>Gesendet: Montag, 22. November 2021, 18:38An: biologist79/ESPuinoCc: GeneralLuzi; AuthorBetreff: Re: [biologist79/ESPuino] MQTT: new brightness values not published (Issue #119) I discovered the same issue today. Fix can be found here: #124 —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

Benjamin Stürmer · Answer 5 · Tue Nov 23 2021 02:40:49 GMT+0800 (China Standard Time)

@GeneralLuzi You can just checkout the branch and deploy it to your device. It will be reviewed this week anyway :D

GeneralLuzi · Answer 6 · Tue Nov 23 2021 03:16:46 GMT+0800 (China Standard Time)

@thebino my test shows 2 out of 3. Well done! 👍

Brightness and SleepTimer I can confirm to be fixed. Somehow LockControls is not publishing the change! Could you have a look please?

Thanks!

Benjamin Stürmer · Answer 7 · Tue Nov 23 2021 04:25:22 GMT+0800 (China Standard Time)

@GeneralLuzi can you pull the latest state and validate if it updates the state now? Haven't tested myself. Just added the fix and pushed it.

biologist79 · Answer 8 · Tue Nov 23 2021 16:47:53 GMT+0800 (China Standard Time)

Merged into master.
@GeneralLuzi Please review if it's working for you.

GeneralLuzi · Answer 9 · Wed Nov 24 2021 04:51:24 GMT+0800 (China Standard Time)

Thanks @biologist79

I retested the feature on the branch of @thebino this morning and it worked. Afterwards I wanted to test the RFID commands in combination with MQTT and discovered a major fail - my SD Card (filesystem?!) was destroyed... Not sure why and how... I am trying to recap... maybe a new issue - maybe just bad luck with the SD card not sure

After fixing the SD Card, I will test the merge and comment again...

biologist79 · Answer 10 · Fri Dec 03 2021 05:47:28 GMT+0800 (China Standard Time)

Can this one be closed?

GeneralLuzi · Answer 11 · Fri Dec 03 2021 09:01:04 GMT+0800 (China Standard Time)

I will close this issue. Thanks for fixing. If there is anything left, I will re-open again.