bids-standard / pybv

A lightweight I/O utility for the BrainVision data format, written in Python.

Home Page:https://pybv.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Allow event durations == 0

cbrnr opened this issue · comments

@sappelhoff you recently introduced a bunch of tests in v0.7.3, among others event durations must be >= 1. However, I frequently have annotations that have no duration (i.e. == 0), which previously could be written. Do you have a reason why you want to enforce durations >= 1?

In a similar vain, #93 seems to be the result of another test that might be to strict.

Hi Clemens - it seems like this is a mistake, the format spec clearly allows for >= 0, not > 0, see:

https://www.brainproducts.com/download/specification-of-brainvision-core-data-format-1-0/

image

However note:

image

a PR to fix this is welcome!