Create a readthedocs page
choldgraf opened this issue · comments
hey @chrisfilo can you create a readthedocs page for this repository? I don't think I have permissions to do so...
You should have all the permissions - could you try: https://readthedocs.org/dashboard/import/manual/?
ah ok - I think it's up, closing now, thanks!
It's up but there is no content on it yet ... do we need to push our docs to it somehow?
argg, the content is there but the build failed because we didn't install pybv as a part of the docs build. We need to add it to the docs requirements.txt file so that RTD can build with it.
@sappelhoff what's your readthedocs username? I'll add you as an admin
ahh okay, I don't have that much experience with readthedocs, but I'll learn more about it. My username there is sappelhoff
.
cool, just added you
was this line supposed to be the installation of pybv?
Line 42 in bb49c1d
yeah I think this would do the trick until we can get it up on pip
@choldgraf fyi ... the whole issue was fixed by ticking this box (see screenshot below) and adding our requirements.txt
in the Settings of readthedocs ... the changes we did over CircleCI did not have any effect, because readthedocs creates its own environment instead of pulling already built docs over ...
docs are now testing AND building correctly ... and always referencing to "stable":