services/ftp: Integration tests failed with internal error

Question

services/ftp: Integration tests failed with internal error

Xuanwo opened this issue 3 years ago · comments

related test: https://github.com/beyondstorage/go-storage/runs/3935965835

       When Read with offset and size 
        The error should be nil ✘✔
        The content should be match ✔✔✔✔

   * /home/runner/work/go-storage/go-storage/services/ftp/tests/storage_test.go 
  Line 14:
  Expected: nil
  Actual:   'read: Storager ftp {URL: 127.0.0.1:2121, User: admin, WorkDir: /}, [c17c9997-4332-4b75-a4d5-fed48a1da776]: service internal, 426 Data connection error.'

Xuanwo · Answer 1 · Sat Oct 23 2021 13:43:36 GMT+0800 (China Standard Time)

The error happened while read with size and offset randomly only on mina/ftpserver, other cases are OK.

Server side code: https://gitbox.apache.org/repos/asf?p=mina-ftpserver.git;a=blob;f=core/src/main/java/org/apache/ftpserver/command/impl/RETR.java;h=c8afcf261c508ce1540b6052616ed6dab6793ff1;hb=HEAD#l188

Xuanwo · Answer 2 · Sat Oct 23 2021 14:02:43 GMT+0800 (China Standard Time)

It looks more like a server-side error, maybe we need to report an error to https://issues.apache.org/jira/projects/FTPSERVER/issues/FTPSERVER-502?filter=allopenissues

- ASF JIRA

Xuanwo · Answer 3 · Sat Oct 23 2021 14:05:45 GMT+0800 (China Standard Time)

BTW, I think mina/ftpserver is not actively maintained according to their VSC changes:

The version we used for testing is released on 2017-4-15 which is 4 years ago.

Xuanwo · Answer 4 · Sat Oct 23 2021 14:10:41 GMT+0800 (China Standard Time)

Before we find out what happend on mina/ftpserver, I think we can move those tests to vsftpd instead.