beyondstorage / go-storage

A vendor-neutral storage library for Golang: Write once, run on every storage service.

Home Page:https://beyondstorage.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

sevices/s3: Migrate to aws-sdk-go-v2: Some configs are gone

Joey-1445601153 opened this issue · comments

commented

In aws-sdk-go-v2, some old configs in service are gone.Check the differences of aws.config in Reference.

In aws-sdk-go-v2, configs like S3DisableContentMD5Validation,LowerCaseHeaderMaps are gone.
We shoud figure out whether they are needed and without these configs whether problems will occur.

Reference

aws.config in aws-sdk-go
aws.config in aws-sdk-go-v2

List of Gone Configs

  1. S3DisableContentMD5Validation
  2. LowerCaseHeaderMaps
  3. S3ForcePathStyle
  4. S3Disable100Continue(Not found)
  5. S3UseARNRegion

Steps

  • Figure out whether those configs are actually needed
  • Find other way to set necessary configs, and ignore unnecessary configs.

some old configs in service are gone.

Please give more information here. Which configs are gone? Why? What's the plan?

commented

Please give more information here. Which configs are gone? Why? What's the plan?

I changed the description of this issue.I want to know does it meet our specifications?

S3DisableContentMD5Validation,LowerCaseHeaderMaps,...

Can you provide a clear list here?

S3Disable100Continue is not found in AWS Go SDK, let's remove it for now.