beyondcode / laravel-favicon

Create dynamic favicons based on your environment settings.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make it a dev dependency

winkbrace opened this issue · comments

Very nice little quality of life feature.

But I only need this dependency in my development and test environments, so it qualifies as a dev dependency. So the first thing I did was add a custom helper method for the production environment.

/**
 * Placeholder for the laravel-favicon package that doesn't exist on production
 */
if ( ! function_exists('favicon') && env('APP_ENV') == 'production') {
    function favicon($image)
    {
        return $image;
    }
}

I'm sure you already thought about this, but I'd like to propose adding this option to the readme. What do you think?

What about developers who wants use it on production too? :)

I have the feeling this is not really actively maintained anymore. :)
So I'm closing this issue. It was just a question anyway.