bevacqua / js

:art: A JavaScript Quality Guide

Home Page:https://ponyfoo.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Style checking is not painful

imavroukakis opened this issue · comments

You need to quantify why style checking is painful. Your statement is especially contradicting as enforcing braces is something that the style tool you link to will actually do. I have never worked in a shop where a style of code wasn't enforced. Agreeing on a style might be arbitrary but it's usually done for a good reason.

It's a waste of everyone's time, I'd be fine with implementing only the enforced braces rule, but that's never how it goes. Most likely, whoever is in charge of implementing the style checks will throw in a few more constraints that are just going to slow down development for no gain, which is why I say avoid them altogether.

Perhaps but your assumption here is of an overlord. These things are done as a team consensus or at the very least crushing majority 😄 Once everyone's in agreement of the style their shop needs/wants to follow, then I see no impediment.

The impediment is that it provides little gain while being super obnoxious. You don't have to follow these guidelines, they are just what I'm comfortable with, and that's upholding quality while not having a build fail because I added a space between function and ()

A verbal agreement or a written style guide is better than having a mindless worker blindly listening to an obnoxious style checker

Most likely, whoever is in charge of implementing the style checks will throw in a few more constraints that are just going to slow down development for no gain, which is why I say avoid them altogether.

So you detest style checkers because of the people creating them? I don't see how that has any bearing on the benefits of automated code style checking.

A verbal agreement or a written style guide is better than having a mindless worker blindly listening to an obnoxious style checker

Except when your "preferred style" changes. Why would a tool that only check agreed upon rules be obnoxious?

Because it puts the focus on the wrong place.

Who cares if a couple of methods have an extra space in a comma-separated list of arguments? It can be super tedious, I suggest a more relaxed approach, that's it. I'm not saying don't use it ever ever, but just be really conscious about what you're doing.

I absolutely agree that the focus shouldn't be on code style at all - that's the entire reason for me to use a linter that is strict on code style. That way my colleagues and I can focus on what's important.

Thanks for the clarification.