bevacqua / css

:art: CSS: The Good Parts

Home Page:https://ponyfoo.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

btn-red is almost never a good class name

bcullman opened this issue · comments

Under the section entitled "Styles", I believe you were trying to point out how to avoid the use of !important, which is reasonable. however, I think using "btn-red" as a style name under a subheading of "Good" may also give the impression that the class name is a good one.

It is preferable to describe the semantic meaning of the button is red (warning? error?) rather than the color, so it can be later altered by the designer (can we make it orange?) without causing a semantic disconect

Feel free to submit a PR to clarify

Submitted a PR which should fix this issue.