bevacqua / css

:art: CSS: The Good Parts

Home Page:https://ponyfoo.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Frameworks and Vendor Styles

talmand opened this issue · comments

The subheadings need to be smaller than the parent heading so they display as subheadings. Actually, skip this, I now see it isn't necessary.

Under the "Not Stylus" subheading, "Use a single space after the colon" and "Put spaces after : in property declarations" are fundamentally the same thing. Also, the first example under "bad" has #foo instead of #f00;. Letters versus numbers in other words.

Under the "CSS" subheading, the examples in the list use .foo and .bar as classes. In the "Good" and "Bad" examples foo is used in a comment while classes are .bar and .baz. I would suggest using .foo and .bar as classes and display the comment using the word comment instead.

Feel free to submit PRs that fix these issues and we can discuss your changes

Submitted a fix for the redundant rules around :'s in #8.

Is there a reason this is still open? Are there issues brought up in this that still need to be addressed?