betodealmeida / gsheets-db-api

A Python DB-API and SQLAlchemy dialect to Google Spreasheets

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Not working with newer moz-sql-parser

epol opened this issue · comments

When I install newer versions of moz-sql-parser queries aren't parsed and the following error is returned:

Invalid URL, must be a docs.google.com URL!

Digging into the problem I found that moz_sql_parser.parse used in extract_url changed in commit 3557475 and so in all releases after 4.10.21011.

The new version escapes the dots in the URL, so instead of https://docs.google.com/spreadsheets/d/1_rN3lm0R_bU3NemO0s9pbFkY5LQPcuy1pscv8ZXPtg8/ we get back https://docs\\.google\\.com/spreadsheets/d/1_rN3lm0R_bU3NemO0s9pbFkY5LQPcuy1pscv8ZXPtg8/

For the moment I fixed it installing moz-sql-parser==4.9.21002, do you think this issue should be solved in this project or in the moz-sql-parser code?

Issue #14 may be related