Make the token not found warning configurable
zagl opened this issue · comments
Currently the message text is hard-coded which is a problem if someone wants to change the language. It would be better if the text was a variable in settings.py.
django-magicauth/magicauth/views.py
Lines 148 to 153 in 5baa9ce
Hi @zagl , thanks for the issue.
Do you need this language customisation ? Is it blocking your adoption ? Or is it just a nice-to-have ?
I'd advocate in favour of using translations mechanisms for this kind of customisations to avoid polluting the settings.py
.
Hi @zagl , thanks for the issue. Do you need this language customisation ? Is it blocking your adoption ? Or is it just a nice-to-have ?
I need it, yes. But it is not blocking at the moment. I just override the get method completely.
I'd advocate in favour of using translations mechanisms for this kind of customisations to avoid polluting the
settings.py
.
That sounds reasonable.