Dont rely on PHP globals for cookies

Question

Dont rely on PHP globals for cookies

Haehnchen opened this issue 5 years ago · comments

Daniel Espendiller commented 5 years ago

For activating cookies there is a directy access to $_COOKIE, for now its not suitable to use together with the Symfony bundle.

You should move this loading into a interface and maybe provide here just an implementation via globals. The Symfony bundle should then use a RequestStack implementation.

return in_array($name, array_map('trim', explode($this->separator, $_COOKIE[$this->name])), true);

Michel Chowanski · Answer 1 · Fri Jun 07 2019 14:27:18 GMT+0800 (China Standard Time)

Thanks for the hint @Haehnchen. I will check it ...

Michel Chowanski · Answer 2 · Sat Oct 05 2019 02:15:23 GMT+0800 (China Standard Time)

Merged into master.

Michel Chowanski · Answer 3 · Sat Oct 05 2019 02:15:38 GMT+0800 (China Standard Time)

A PR for Bundle will be created shortly.