benwiley4000 / volca-sampler

Send a new sound to your volca sample!

Home Page:https://volcasampler.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

failedPluginIndex should update when audio preview fails

benwiley4000 opened this issue · comments

Hard to know exactly how to do this since previewAudio can be requested from several places.

Another solution could be to have some separate runtime-only state tracking failed plugins, and we cross-reference both wherever failedPluginIndex would be checked.

I guess we need a getPluginStatus function that checks if a plugin is missing, broken or installed.

We need to check this plugin status on the sampledetail as well as when preparing to transfer a bunch of samples. In each place we need to be able to reload the plugins that are broken.

In the case of bulk transfer we need to offer a button to try to reload plugins if some are broken but no plugins are marked as failed in any of the sample caches.

In the case of sampledetail we don't distinguish from a plugin that failed to load versus a failed plugin index in the sample cache. We will mark plugins that have issues and just a single button to try to reload all broken plugins. We need to make sure not to reload a plugin twice, so we the install function to de-duplicate.