Coins with 0 value are displayed despite having set minValueBtc
gosuto-inzasheru opened this issue · comments
If I understand correctly, setting minValueBtc makes CryptoETF ignore coins which have a value under a certain threshold. Good for ignoring dust or coins with zero balance. Much like the "Hide 0 Balances" option on Poloniex' balance page.
However, I am doubting whether minValueBtc is doing what it says it does. The only time it is checked (as far as I can tell) is by updateHighestRankWithBalance(). This means that despite having minValueBtc set, coins with a value below minValueBtc are still displayed.
Yes you're understanding is correct.
So basically right now the tool will keep track of the coin amount with the lowest rank > minValueBtc. E.g. if you own a fraction of a coin at rank 240, we commit that and only display the Top40 (if you own the 40. coin with more than minValueBtc).
I hope that makes sense to you... Happy to consider alternatives :)
Actually please take a look at: https://github.com/benmarten/CryptoETF/blob/master/settings.example.json#L61
That should solve your issue. Setting this to true will hide all coins that you don't actually own.
Implemented in: #9