1.0.3 breaks in environments without module

Question

1.0.3 breaks in environments without module

Rich-Harris opened this issue 8 years ago · comments

Hi – my app (which uses most, which depends on symbol-observable) is breaking after the release of 1.0.3, apparently due to #23. 1750d26 assumes that module exists, which is only true in Node or Node-like environments.

Let me know if you're interested in a PR that puts the module reference behind a typeof.

Ben Lesh · Answer 1 · Wed Oct 12 2016 04:59:33 GMT+0800 (China Standard Time)

Oops. I missed that in my review. Thank you.

Denis Bardadym · Answer 2 · Wed Oct 12 2016 23:02:03 GMT+0800 (China Standard Time)

@Blesh could you please publish this to npm?

Ben Lesh · Answer 3 · Fri Oct 14 2016 05:01:53 GMT+0800 (China Standard Time)

@btd done in 1.0.4. Sorry for the delay.