benlesh / rxjs-for-await

A library for making RxJS support async-await for-await loops via AsyncIterables

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support rxjs 6 and 7 as a bugfix version 0.0.3

WolfspiritM opened this issue · comments

Hi,

Would it be possible to make a version based on 0.0.2 that supports rxjs 6 and 7?

Currently many peope using nx to maintain angular projects are not able to update to rxjs 7 cause nrwl/angular references 0.0.2. While at the same time nrwl/angular can't upgrade to rxjs-for-await 1.0.0 cause many people might still be using rxjs 6. nrwl angular needs to support both for now.

Even so toPromise is depreacted in rxjs 7 I think it would be a good solution to have a version 0.0.3 that uses that deprecated api and just adds rxjs 7 as peerDependency.

See also: nrwl/nx#10308

hey @benlesh!

Could you please consider releasing a new version (either 0.0.3 or 1.0.1) with the rxjs peerDependency set to ^6.0.0 || ^7.0.0. I was looking at the commit that added support for rxjs 7 and I couldn't find any change that requires v7. Unless I'm missing something, it seems like the current version should support both rxjs versions correctly.

As the OP mentioned, this would be particularly useful for Nx where support for both versions is still needed.