benkingcode / ember-routable-modal

An ember-cli addon for implementing URL-first modals.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Doesn't work with Ember FastBoot

courthead opened this issue · comments

The checks in the current-routed-modal service fail in FastBoot mode. This seems to be because the checks are merely looking whether $ or window are undefined, but it seems to be possible for both to be defined in FastBoot mode, because that's what's happening to me.

I'm not sure what the most reliable check is. Ensuring document is undefined seems to work. Injecting the fastboot service and checking its isFastBoot property seems to work, too.