benkingcode / ember-routable-modal

An ember-cli addon for implementing URL-first modals.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

currentRouteName assertions fail in tests when afterModel block runs in route mixin

gmurphey opened this issue · comments

Here's a branch with failing tests illustrating the issue:
https://github.com/metricly/ember-routable-modal/tree/current-route-name-test-failures

It seems that the transition isn't completed when the modal isn't the route used for the initial transition.

https://github.com/dbbk/ember-routable-modal/blob/134d665fcd1912331f766e09f9db2c8987c1e7ee/addon/mixins/route.js#L58-L76