benjojo / mcod

Minecraft servers that only run when people are playing on them

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Handle handshake packet

xPaw opened this issue · comments

http://wiki.vg/Protocol#Handshake

You won't need to start the server, unless it's actually a login handshake, and reply with motd banner data when needed.

Done 🎉

screenshot from 2015-02-02 23 13 22

Here is what it looks like in action, Note the backend is down, but the banner at the top still lives

Your current implementation is quite buggy. Most of the time it just shows 'Pinging...' in Minecraft, and I think it somehow caches login response, instead of banner response. It's also possible to trigger 'new player joining' by just refreshing the server list. And when you try join the server, it says 'Serving the banner from cache' instead.

Can you try and record a video to reproduce (show the back end port and the one covered by mcod + the output) so I can look into this?

I did try and ensure that this would not munch anything up but I might be wrong