Strange not not found error

[Ilya Kantor]

Hello,

Could you please explain, how's that possible?

source.nodes().at(0).program.body.at(0).body.body.at(0).body.body.at(0).expression.arguments.at(0).arguments.at(0).params.at(0).typeAnnotation.typeAnnotation.elementTypes[1].type
'TSTypeReference'

source.find(jscodeshift.TSTypeReference).length
0

In other words, I can access the node, but it's not found. WAT? 😮

Here's the code:

class SelectedFiltersComponent {
  public ngOnInit(): void {
    combineLatest()
      .pipe(
        map(([data, selectedData]: [IFilterData, IFilterParams]) => {
          return items;
        }),
      )
  }
}

As you can see, there're at least two TypeReference nodes IFilterData and IFilterParams, but for some reason they're not found.

[Ben Newman]

@iliakan Can you try npm i recast@next?

[Ilya Kantor]

It's with recast@next ;)

[Ilya Kantor]

I thought... Maybe there's a limitation inside find... Such as it doesn't go into some types of nodes...

[Ilya Kantor]

@benjamn Also, here it can't find IPaginatedItems.

Tried to make it as simple as possible. May be related.

export class A {

  public test: () => void = () =>

      pluck<IPaginatedItems>('data')

}

[Brian Donovan]

This looks like a bug in jscodeshift. Using recast and @babel/core visits those nodes just fine:

import { transform } from '@codemod/core';

const sources = [`
  class SelectedFiltersComponent {
      public ngOnInit(): void {
        combineLatest()
          .pipe(
            map(([data, selectedData]: [IFilterData, IFilterParams]) => {
              return items;
            }),
          )
      }
    }
`,
`
  export class A {

    public test: () => void = () =>

        pluck<IPaginatedItems>('data')

  }
`
];

for (const source of sources) {
  transform(source, {
    plugins: [
      {
        visitor: {
          TSTypeReference(path) {
            // prints:
            //   IFilterData
            //   IFilterParams
            //   IPaginatedItems
            console.log(source.slice(path.node.start, path.node.end));
          }
        }
      }
    ],
  });
}