Error: did not recognize object of type "TSInstantiationExpression"

Question

Error: did not recognize object of type "TSInstantiationExpression"

Arooba-git opened this issue 2 years ago · comments

Hi 👋
I'm using recast with babel parser, and getting this error when trying to parse any file containing TSInstantiationExpression. Is recast missing TSInstantiationExpression support or am I missing something? 🤔

Arooba Shahoor commented 2 years ago

bump

Ilya Kantor · Answer 1 · Fri Dec 09 2022 18:34:27 GMT+0800 (China Standard Time)

Is there any workaround or a temporary fix for that? I'd be happy to ignore these, just not to die.

My jscodeshift-based auto-refactoring script fails to work on real-life files because of that. Even though it doesn't need to refactor any TSInstantiationExpressions.

Brian Donovan · Answer 2 · Sat Dec 10 2022 04:59:33 GMT+0800 (China Standard Time)

Does it fail on every file? Or only files with TSInstantiationExpressions? You could comment them out for now.

Ilya Kantor · Answer 3 · Sat Dec 10 2022 05:35:26 GMT+0800 (China Standard Time)

I have a large codebase, 100+ files have TSInstantiationExpressions. The refactoring script fails on them.

Ilya Kantor · Answer 4 · Tue Dec 13 2022 06:14:16 GMT+0800 (China Standard Time)

Without any type of pressure, may I kindly wonder, is this going to be fixed soon?

I saw a commit has landed, but not sure how much work is ahead.

Thank you for what you do!

Ben Newman · Answer 5 · Tue Dec 13 2022 22:59:55 GMT+0800 (China Standard Time)

The remaining work in #1232 is worthwhile for completeness but not necessarily relevant unless you're using ClassAccessorProperty (a very new AST node type).

@iliakan If you want to test the current changes locally, you should be able to run this command to install recast@0.23.0-pr1232.0:

npm i recast@pr-1232

If this is useful, let me know. I might try to automate it for any PR, so it's easier for folks to test/use any proposed changes.

Brian Donovan · Answer 6 · Thu Dec 15 2022 00:40:37 GMT+0800 (China Standard Time)

I've updated the pr-1232 tag with the latest from #1232. Working for you, @iliakan?

Ilya Kantor · Answer 7 · Thu Dec 15 2022 05:18:46 GMT+0800 (China Standard Time)

Last time it worked without errors (but I did not check the outcome). I'll retest again after I rewrite some stuff ;)

Ben Newman · Answer 8 · Thu Dec 15 2022 07:04:03 GMT+0800 (China Standard Time)

Alright folks, please try running npm i recast@next to get version 0.23.1, which includes support for TSInstantiationExpression and some other AST types that were lagging behind Babel.

Since I have not tagged this version as latest on npm yet, we can still fix bugs relatively easily, if you encounter anything strange after updating.