benjamn / ast-types

Esprima-compatible implementation of the Mozilla JS Parser API

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ForOfStatement no longer bases Statatment

Pajn opened this issue · comments

The change 1dc9fcc#diff-8f6976804758eb4b8d3e5ead3454d636R47 removes .bases("Statement") from def("ForOfStatement").

Is this change intentional?

It creates problems like this in prettier

    -/*a*/
    -for (x of y); //b //c
    +for (x of /*a*/ //b
    +y); //c

and

    -for (var x of delegate_yield_generator()) {
    +for (var x; of delegate_yield_generator()) {

I don't have full understanding how this is supposed to work so I thought I should ask if it's intentional before I start to investigate another fix 😄