Clarify browser support
fvsch opened this issue · comments
Hi,
Wondering if it would be possible to clarify the current browser support in the README? E.g. adding a "Browser Support" section at the end.
Cool project btw, thanks for sharing!
Did a quick test of the demos:
- Edge works fine, with one alignment bug on http://animateplus.com/demos/download-button/ (arrow shape is aligned to the top left, instead of center top).
- IE11 doesn't work, not sure if it's because of lack of essential features or because of fixable JS bugs.
Yeah I dropped IE11 support with release 1.4. Agreed I should document browser support as I tend to be fairly aggressive in that regard :p
@bendc You can be aggresive, but you should have followed Semver and released it as 2.0.
I guess you're right. I thought a minor release would be appropriate since I haven't introduced API changes but, yeah, should likely have been labeled as major.
@bendc Here's a simple rig to model after if you want to package up this library: https://github.com/jhabdas/fetch-inject. Utilizes Semantic Release to make versioning and deployment to NPM and Bower as simple as a commit comment, push.
Also, thanks for this library. I'm digging the pithy API. It would pair well with the library linked to provide animations without causing a blocking external request:
const animationOpts = {el: "div", opacity: 0}
fetchInject(['/js/vendor/animate.min.js']).then(() => animate(animationOpts))Fixed in v2.0.0