Adding a --check flag for ci
adamgen opened this issue · comments
Background
Barrelsby should be used solely while developing, thus compiled barrels should be present while creating PRs.
Proposal
To validate this process, add a --check flag that will not output to the filesystem. Instead, it will compare the desired outputs with the current file system and exit with a non-zero code if there is such a difference. Desirable with some details about which files weren't added during the development phase.
As a walkaround, I'm running this in my CI to check if there are changed files after running barrelsby.
barrelsby && git diff --exit-code
No activity has been seen recently, marking as stale. If this is a mistake please reach out to a collaborator
Inspired by the integration-tests script I think that a simple implementation for it would be to:
- Make a simple run with modified index names. Let's say
.barrelsby-index.check.ts. - Compare these new
.barrelsby-index.check.tswith the ordinaryindex.tswhile ignoring whitespaces. - Prompt the user if the check passed successfully or not.
- Delete the
.barrelsby-index.check.tsfiles.
@BitForger, @bencoveney does this sound like a bad idea?
Sorry, as you can tell we've both been pretty busy with the personal lives.
My idea for implementation would probably be to walk through and do everything up until the point of creating the file and just compare the contents of the existing file with the string we created in memory. If it matches we exit 0 and if not we exit 1 with the differences if that isn't too hard to do.
No activity has been seen recently, marking as stale. If this is a mistake please reach out to a collaborator
No activity has been seen recently, marking as stale. If this is a mistake please reach out to a collaborator