searchMusicLibrary -> Albums with ":" or "/" does not work
yoogie27 opened this issue · comments
I am using sonos-web and having issues with some albums. I tracked it down to albums having either ":" or "/" in the name. The backend code calls this.sonos.searchMusicLibrary("albums", "Series1 : Blabla", { start: 0, total: 100}, "/")
Expected Behavior
Return album content
Current Behavior
Empty result
Versions (and Environment)
Node version: v8.12.0
node-sonos version: v0.19.0
OS: Mac / Linux
Potential solution:
In lib/sonos.js, line 120, replace encodeURI with encodeURIComponent
This got something to do with the fact that Sonos used these special characters as delimiter to mark levels when browsing the library will you be creating a PR for it?
Searching for artist Eminem A:ARTIST:Eminem will result in a list of Artists. A:ARTIST/Eminem will result in a list of songs by Eminem. The : and / are special and should be encoded if in the name.
Will do after new year's eve
🎉 This issue has been resolved in version 1.12.6 🎉
The release is available on:
Your semantic-release bot 📦🚀